linux-kernel - RE: [PATCH] PCI: layerscape: Change back to the default error response behavior

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HE1PR0402MB3371AAA60147CAB24C63E2E384070@HE1PR0402MB3371.eurprd04.prod.outlook.com>
Date:   Mon, 12 Oct 2020 04:33:32 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     Rob Herring <robh@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>
CC:     PCI <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "M.h. Lian" <minghuan.lian@....com>, Roy Zang <roy.zang@....com>,
        Mingkai Hu <mingkai.hu@....com>, Leo Li <leoyang.li@....com>
Subject: RE: [PATCH] PCI: layerscape: Change back to the default error
 response behavior

Hi Rob and Kishon,

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 2020年9月30日 23:08
> To: Kishon Vijay Abraham I <kishon@...com>
> Cc: Z.q. Hou <zhiqiang.hou@....com>; PCI <linux-pci@...r.kernel.org>;
> linux-kernel@...r.kernel.org; linux-arm-kernel
> <linux-arm-kernel@...ts.infradead.org>; Lorenzo Pieralisi
> <lorenzo.pieralisi@....com>; Bjorn Helgaas <bhelgaas@...gle.com>; M.h.
> Lian <minghuan.lian@....com>; Roy Zang <roy.zang@....com>; Mingkai
> Hu <mingkai.hu@....com>; Leo Li <leoyang.li@....com>
> Subject: Re: [PATCH] PCI: layerscape: Change back to the default error
> response behavior
> 
> On Wed, Sep 30, 2020 at 8:29 AM Kishon Vijay Abraham I <kishon@...com>
> wrote:
> >
> > Hi Hou,
> >
> > On 29/09/20 6:43 pm, Zhiqiang Hou wrote:
> > > From: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > >
> > > In the current error response behavior, it will send a SLVERR
> > > response to device's internal AXI slave system interface when the
> > > PCIe controller experiences an erroneous completion (UR, CA and CT)
> > > from an external completer for its outbound non-posted request,
> > > which will result in SError and crash the kernel directly.
> > > This patch change back it to the default behavior to increase the
> > > robustness of the kernel. In the default behavior, it always sends
> > > an OKAY response to the internal AXI slave interface when the
> > > controller gets these erroneous completions. And the AER driver will
> > > report and try to recover these errors.
> >
> > I don't think not forwarding any error interrupts is a good idea.
> 
> Interrupts would be fine. Abort/SError is not. I think it is pretty clear what the
> correct behavior is for config accesses.

I agree with Rob.

> 
> > Maybe
> > you could disable it while reading configuration space registers
> > (vendorID and deviceID) and then enable error forwarding back?
> 
> To add to the locking (or lack of) problems in config accesses?

If take this approach, during the hole of CFG access, the error of MEM_rd will also not be forwarded, so it's not a reliable mechanism for user.

Thanks,
Zhiqiang

> 
> Rob