[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201013090511.1f2f71f6@gandalf.local.home>
Date: Tue, 13 Oct 2020 09:05:11 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Yafang Shao <laoar.shao@...il.com>
Cc: mingo@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: add tgid into common field
On Tue, 13 Oct 2020 13:54:54 +0800
Yafang Shao <laoar.shao@...il.com> wrote:
> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -67,6 +67,7 @@ struct trace_entry {
> unsigned char flags;
> unsigned char preempt_count;
> int pid;
> + int tgid;
> };
>
Sorry, this adds another 4 bytes to *every* event, if you want it to or
not. I'd rather have some ways to remove fields from this header, and not
add more to it.
I can't take this patch.
-- Steve
Powered by blists - more mailing lists