linux-kernel - Re: [PATCH] tracing: add tgid into common field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALOAHbBb2D+iYHfaXaE+Nux7EtxwLW-cT-BXw2=o_2nfMYakmw@mail.gmail.com>
Date:   Tue, 13 Oct 2020 22:48:52 +0800
From:   Yafang Shao <laoar.shao@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Ingo Molnar <mingo@...hat.com>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing: add tgid into common field

On Tue, Oct 13, 2020 at 9:05 PM Steven Rostedt <rostedt@...dmis.org> wrote:
>
> On Tue, 13 Oct 2020 13:54:54 +0800
> Yafang Shao <laoar.shao@...il.com> wrote:
>
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -67,6 +67,7 @@ struct trace_entry {
> >       unsigned char           flags;
> >       unsigned char           preempt_count;
> >       int                     pid;
> > +     int                     tgid;
> >  };
> >
>
> Sorry, this adds another 4 bytes to *every* event, if you want it to or
> not. I'd rather have some ways to remove fields from this header, and not
> add more to it.
>
> I can't take this patch.
>

Right, that is an overhead. I will think about some ways to avoid adding it.


-- 
Thanks
Yafang