linux-kernel - Re: [PATCH] DMA: PL330: Remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014043933.GQ2968@vkoul-mobl>
Date:   Wed, 14 Oct 2020 10:09:33 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Surendran K <surendran.k@...sung.com>
Cc:     dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
        shaik.ameer@...sung.com, alim.akhtar@...sung.com,
        pankaj.dubey@...sung.com
Subject: Re: [PATCH] DMA: PL330: Remove unreachable code

On 13-10-20, 17:17, Surendran K wrote:
> _setup_req(..) never returns negative value.
> Hence the condition ret < 0 is never met

The subsystem is "dmaengine", git log would tell you the tags to use


> 
> Signed-off-by: Surendran K <surendran.k@...sung.com>
> ---
>  drivers/dma/pl330.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index e9f0101d92fa..8355586c9788 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1527,8 +1527,6 @@ static int pl330_submit_req(struct pl330_thread *thrd,
>  
>  	/* First dry run to check if req is acceptable */
>  	ret = _setup_req(pl330, 1, thrd, idx, &xs);
> -	if (ret < 0)
> -		goto xfer_exit;
>  
>  	if (ret > pl330->mcbufsz / 2) {
>  		dev_info(pl330->ddma.dev, "%s:%d Try increasing mcbufsz (%i/%i)\n",
> -- 
> 2.17.1

-- 
~Vinod