linux-kernel - RE: [PATCH] DMA: PL330: Remove unreachable code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0cc501d6a3a7$6d9203c0$48b60b40$@samsung.com>
Date:   Fri, 16 Oct 2020 03:30:53 -0700
From:   "Surendran K" <surendran.k@...sung.com>
To:     "'Vinod Koul'" <vkoul@...nel.org>
Cc:     <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <shaik.ameer@...sung.com>, <alim.akhtar@...sung.com>,
        <pankaj.dubey@...sung.com>
Subject: RE: [PATCH] DMA: PL330: Remove unreachable code

Hi Vinod,
Thanks for pointing it out, I missed it. Will send V2 with correction.

Regards,
Surendran.

-----Original Message-----
From: Vinod Koul [mailto:vkoul@...nel.org] 
Sent: Tuesday, October 13, 2020 9:40 PM
To: Surendran K <surendran.k@...sung.com>
Cc: dmaengine@...r.kernel.org; linux-kernel@...r.kernel.org;
shaik.ameer@...sung.com; alim.akhtar@...sung.com; pankaj.dubey@...sung.com
Subject: Re: [PATCH] DMA: PL330: Remove unreachable code

On 13-10-20, 17:17, Surendran K wrote:
> _setup_req(..) never returns negative value.
> Hence the condition ret < 0 is never met

The subsystem is "dmaengine", git log would tell you the tags to use


> 
> Signed-off-by: Surendran K <surendran.k@...sung.com>
> ---
>  drivers/dma/pl330.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c index 
> e9f0101d92fa..8355586c9788 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -1527,8 +1527,6 @@ static int pl330_submit_req(struct pl330_thread 
> *thrd,
>  
>  	/* First dry run to check if req is acceptable */
>  	ret = _setup_req(pl330, 1, thrd, idx, &xs);
> -	if (ret < 0)
> -		goto xfer_exit;
>  
>  	if (ret > pl330->mcbufsz / 2) {
>  		dev_info(pl330->ddma.dev, "%s:%d Try increasing mcbufsz
(%i/%i)\n",
> --
> 2.17.1

--
~Vinod