linux-kernel - Re: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201014085251.GS4077@smile.fi.intel.com>
Date:   Wed, 14 Oct 2020 11:52:51 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Michael Wu <michael.wu@...ics.com>,
        Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        Morgan Chang <morgan.chang@...ics.com>,
        Dean Hsiao <dean.hsiao@...ics.com>,
        Paul Chen <paul.chen@...ics.com>
Subject: Re: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

On Wed, Oct 14, 2020 at 03:39:51PM +0800, kernel test robot wrote:
> Hi Michael,
> 
> Thank you for the patch! Yet something to improve:

Wondering if you compile this at all...

>    include/asm-generic/io.h:1017:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
>            return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
>                                                      ~~~~~~~~~~ ^
> >> drivers/i2c/busses/i2c-designware-slave.c:181:42: error: expected ';' after expression
>                            dev->status = STATUS_WRITE_IN_PROGRESS
>                                                                  ^
>                                                                  ;
> >> drivers/i2c/busses/i2c-designware-slave.c:195:22: error: use of undeclared identifier 'STATUS_IDEL'
>                    if (dev->status != STATUS_IDEL) {
>                                       ^
>    7 warnings and 2 errors generated.


-- 
With Best Regards,
Andy Shevchenko