linux-kernel - RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5DB475451BAA174CB158B5E897FC1525B1294238@MBS07.vivotek.tw>
Date:   Wed, 14 Oct 2020 09:58:54 +0000
From:   <Michael.Wu@...ics.com>
To:     <andriy.shevchenko@...ux.intel.com>, <lkp@...el.com>
CC:     <jarkko.nikula@...ux.intel.com>, <mika.westerberg@...ux.intel.com>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kbuild-all@...ts.01.org>, <clang-built-linux@...glegroups.com>,
        <morgan.chang@...ics.com>, <dean.hsiao@...ics.com>,
        <paul.chen@...ics.com>
Subject: RE: [PATCH] i2c: designware: fix slave omitted IC_INTR_STOP_DET

On 10/14/20 4:53 PM, andriy.shevchenko@...ux.intel.com wrote:
> 
> Wondering if you compile this at all...


I'm very sorry that I did not compile it because I only have ARM SoC with my
linux 4.9.170, but I've verified the logic of this patch in my linux.

I'll correct these two syntax errors in next version. The reported
warnings occurs from drivers/i2c/busses/i2c-designware-slave.c:13 seems
not made by this modification. Please correct me if I'm wrong....

> >    include/asm-generic/io.h:1017:55: warning: performing pointer
> arithmetic on a null pointer has undefined behavior
> [-Wnull-pointer-arithmetic]
> >            return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE +
> port;
> >
> ~~~~~~~~~~ ^
> > >> drivers/i2c/busses/i2c-designware-slave.c:181:42: error: expected ';' after
> expression
> >                            dev->status =
> STATUS_WRITE_IN_PROGRESS
> >
> ^
> >
>    ;
> > >> drivers/i2c/busses/i2c-designware-slave.c:195:22: error: use of
> undeclared identifier 'STATUS_IDEL'
> >                    if (dev->status != STATUS_IDEL) {
> >                                       ^
> >    7 warnings and 2 errors generated.
> 
> 
>