linux-kernel - Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdb270ef-bec0-9592-1d33-3339872bbffe@gmail.com>
Date:   Wed, 14 Oct 2020 10:13:04 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Sudeep Holla <sudeep.holla@....com>,
        Cristian Marussi <cristian.marussi@....com>
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH] firmware: arm_scmi: Fix duplicate workqueue name

On 10/14/20 9:18 AM, Sudeep Holla wrote:
> On Wed, Oct 14, 2020 at 02:48:19PM +0100, Cristian Marussi wrote:
> 
> [...]
> 
>>>
>>> I have pushed a version with above change [1], please check if you are
>>> happy with that ?
>>>
>>> [1] https://git.kernel.org/sudeep.holla/linux/c/b2cd15549b
>>
>> I agree with the need to retain _notify name, but I'm not so sure about
>> the above patch...which is:
>>
> 
> I agree, I thought about it and just cooked up this as a quick solution.
> I will move to that, even I wasn't happy with this TBH.

The reason why I went with just dev_name() was such that the workqueue
name and the device nodes under /sys would strictly match, which helps
as an user, and also it avoided the temporary buffer and its size
limitations. However I don't have a strong feeling about this. Sudeep, I
can confirm that:

https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/patch/?id=b2cd15549b1fad6b0725c7a5a89ec3d41723fe8f

works as well for me:

# ls -l /sys/bus/workqueue/devices/
total 0
lrwxrwxrwx    1 root     root             0 Jan  1 00:01
brcm_scmi@...otify -> ../../../devices/virtual/workqueue/brcm_scmi@...otify
lrwxrwxrwx    1 root     root             0 Jan  1 00:01
brcm_scmi@...otify -> ../../../devices/virtual/workqueue/brcm_scmi@...otify
lrwxrwxrwx    1 root     root             0 Jan  1 00:01 scsi_tmf_0 ->
../../../devices/virtual/workqueue/scsi_tmf_0
lrwxrwxrwx    1 root     root             0 Jan  1 00:01 scsi_tmf_1 ->
../../../devices/virtual/workqueue/scsi_tmf_1
lrwxrwxrwx    1 root     root             0 Jan  1 00:01 writeback ->
../../../devices/virtual/workqueue/writeback
-- 
Florian