linux-kernel - Re: [PATCH] tools: net: traceevent: Fix 'snprintf' return value check in 'tep_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201015111852.355049b1@gandalf.local.home>
Date:   Thu, 15 Oct 2020 11:18:52 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Walter Harms <wharms@....de>
Cc:     Fedor Tokarev <ftokarev@...il.com>,
        "acme@...hat.com" <acme@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] tools: net: traceevent: Fix 'snprintf' return value
 check in 'tep_filter_strerror'

On Thu, 15 Oct 2020 15:12:53 +0000
Walter Harms <wharms@....de> wrote:

> i guess the whole thing can be made more simple 
> 
> we have len and buflen
> 
> len=strlen(filter->error_buffer);
> if (len >= buflen )
>   return -1;
> 
> strcpy(buf, filter->error_buffer);
>

Either is fine, but we are moving libtraceevent into it's own library,
which is located here:

  https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/

-- Steve