linux-kernel - Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201015152301.GE438822@phenom.ffwll.local>
Date:   Thu, 15 Oct 2020 17:23:01 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Kever Yang <kever.yang@...k-chips.com>
Cc:     Sandy Huang <hjc@...k-chips.com>, heiko@...ech.de,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, huangtao@...k-chips.com,
        andy.yan@...k-chips.com, linux-rockchip@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

On Wed, Oct 14, 2020 at 09:48:43AM +0800, Kever Yang wrote:
> Hi Maintainers,
> 
>     Does this patch ready to merge?

Would maybe be good to get some acks from other drivers using this, then
Sandy can push to drm-misc-next.
-Daniel
> 
> On 2020/7/7 下午7:25, Sandy Huang wrote:
> > don't mask possible_crtcs if remote-point is disabled.
> > 
> > Signed-off-by: Sandy Huang <hjc@...k-chips.com>
> > ---
> >   drivers/gpu/drm/drm_of.c | 3 +++
> >   1 file changed, 3 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c
> > index fdb05fbf72a0..565f05f5f11b 100644
> > --- a/drivers/gpu/drm/drm_of.c
> > +++ b/drivers/gpu/drm/drm_of.c
> > @@ -66,6 +66,9 @@ uint32_t drm_of_find_possible_crtcs(struct drm_device *dev,
> >   	uint32_t possible_crtcs = 0;
> >   	for_each_endpoint_of_node(port, ep) {
> > +		if (!of_device_is_available(ep))
> > +			continue;
> > +
> >   		remote_port = of_graph_get_remote_port(ep);
> >   		if (!remote_port) {
> >   			of_node_put(ep);
> 
> Looks good to me.
> 
> 
> Reviewed-by: Kever Yang <kever.yang@...k-chips.com>
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch