linux-kernel - Re: [PATCH v4 08/32] auxdisplay: hd44780_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72mfmArumdLBqk-td1HAjxVsfu51zdn=uR=7etq98kYF=A@mail.gmail.com>
Date:   Fri, 16 Oct 2020 05:54:50 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Lars Poeschel <poeschel@...onage.de>
Cc:     open list <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>, Willy Tarreau <w@....eu>
Subject: Re: [PATCH v4 08/32] auxdisplay: hd44780_common_print

On Mon, Oct 5, 2020 at 2:27 PM <poeschel@...onage.de> wrote:
>
> We create a hd44780_common_print function. It is derived from the
> original charlcd_print. charlcd_print becomes a device independent print
> function, that then only calles via it's ops function pointers, into the

Typos: calles -> calls, it's -> its

> + * @clear_fast: Clear the whole display and set cursor to position 0, 0.

This one is optional, but the comment seems to say it isn't (it is
later removed, so in the end it doesn't matter, but probably we should
write "Optional." here too).

> + * @backlight: Turn backlight on or off. Optional.
> + * @print: just Print one character to the display at current cursor position.

Typo: remove "just"

Cheers,
Miguel