linux-kernel - Re: [PATCH] checkpatch: Allow --fix removal of unnecessary break statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49c87dede8d06ba90ecb3200b2a773860d61a3c8.camel@perches.com>
Date:   Sun, 18 Oct 2020 13:19:24 -0700
From:   Joe Perches <joe@...ches.com>
To:     Tom Rix <trix@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Julia Lawall <julia.lawall@...ia.fr>, linux-kernel@...r.kernel.org,
        cocci <cocci@...teme.lip6.fr>
Subject: Re: [PATCH] checkpatch: Allow --fix removal of unnecessary break
 statements

On Sun, 2020-10-18 at 13:07 -0700, Tom Rix wrote:
> I like!
[]
> could add a '|break' here to catch the couple
[]
> break;
> 
> break;

Unfortunately, checkpatch is really stupid and it
wouldn't catch those
cases as there are blank lines
between the existing consecutive break
statements.

It would catch

	break;
	break;

but there aren't any of those so it seems unlikely
to be a very useful addition.