linux-kernel - Re: [PATCH] drm: remove unneeded break

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201019170641.GA963808@ravnborg.org>
Date:   Mon, 19 Oct 2020 19:06:41 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     trix@...hat.com
Cc:     airlied@...hat.com, tzimmermann@...e.de, airlied@...ux.ie,
        daniel@...ll.ch, bskeggs@...hat.com, kraxel@...hat.com,
        gustavoars@...nel.org, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        virtualization@...ts.linux-foundation.org,
        spice-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: remove unneeded break

Hi Tom
On Mon, Oct 19, 2020 at 09:31:15AM -0700, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> A break is not needed if it is preceded by a return or break
> 
> Signed-off-by: Tom Rix <trix@...hat.com>

Looks good and builds with no warnings.

One of the diffs made me - "oh this looks wrong". But after I looked again
it was right and the resulting code is more readable - so good.

Acked-by: Sam Ravnborg <sam@...nborg.org>

Was tempted to just apply to drm-misc-next but will give others the
opportunity to chime in.

	Sam