linux-kernel - Re: [PATCH 06/11] firmware: arm_scmi: add support for protocol modularization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Oct 2020 22:47:28 -0400
From:   Thara Gopinath <thara.gopinath@...aro.org>
To:     Cristian Marussi <cristian.marussi@....com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     sudeep.holla@....com, lukasz.luba@....com,
        james.quinlan@...adcom.com, Jonathan.Cameron@...wei.com,
        f.fainelli@...il.com, etienne.carriere@...aro.org,
        vincent.guittot@...aro.org, souvik.chakravarty@....com
Subject: Re: [PATCH 06/11] firmware: arm_scmi: add support for protocol
 modularization



On 10/14/20 11:05 AM, Cristian Marussi wrote:
> Modify protocol initialization callback adding a new parameter representing
> a reference to the available xfer core operations and introduce a macro to
> simply register with the core new protocols as loadable drivers.
> Keep standard protocols as builtin.
> 
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
>   drivers/firmware/arm_scmi/base.c    | 56 ++++++++++--------
>   drivers/firmware/arm_scmi/bus.c     | 14 ++++-
>   drivers/firmware/arm_scmi/clock.c   | 56 +++++++++---------
>   drivers/firmware/arm_scmi/common.h  | 42 +++++++++-----
>   drivers/firmware/arm_scmi/driver.c  | 50 ++++++++++------
>   drivers/firmware/arm_scmi/perf.c    | 88 +++++++++++++++--------------
>   drivers/firmware/arm_scmi/power.c   | 46 ++++++++-------
>   drivers/firmware/arm_scmi/reset.c   | 46 ++++++++-------
>   drivers/firmware/arm_scmi/sensors.c | 52 +++++++++--------
>   drivers/firmware/arm_scmi/system.c  | 16 ++++--
>   include/linux/scmi_protocol.h       | 18 +++++-
>   11 files changed, 288 insertions(+), 196 deletions(-)
> 
> diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c
> index f40821eeb103..8d7214fd2187 100644
> --- a/drivers/firmware/arm_scmi/base.c
> +++ b/drivers/firmware/arm_scmi/base.c
> @@ -15,6 +15,8 @@
>   #define SCMI_BASE_NUM_SOURCES		1
>   #define SCMI_BASE_MAX_CMD_ERR_COUNT	1024
>   
> +static const struct scmi_xfer_ops *ops;

Minor nit. I would consider renaming ops to something more
meaningful like xfer_ops (or anything that makes sense). ops by
itself leads to confusion with ops in scmo_protocol and  in 
scmi_protocol_events.

Same suggestion for all other declarations of ops in this patch.

-- 
Warm Regards
Thara