linux-kernel - Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add F2FS_IOC_GET_COMPRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACOAw_zVO8FugS_UAXCYyg99-6GWCm4aGi4xEtrhxeBofa2=cA@mail.gmail.com>
Date:   Thu, 22 Oct 2020 13:30:36 +0900
From:   Daeho Jeong <daeho43@...il.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, kernel-team@...roid.com,
        Daeho Jeong <daehojeong@...gle.com>
Subject: Re: [f2fs-dev] [PATCH v2 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

Yep, it sounds more clear~

2020년 10월 22일 (목) 오후 1:22, Eric Biggers <ebiggers@...nel.org>님이 작성:
>
> On Thu, Oct 22, 2020 at 12:58:47PM +0900, Daeho Jeong wrote:
> > +     if (!f2fs_compressed_file(inode)) {
> > +             inode_unlock(inode);
> > +             return -EINVAL;
> > +     }
>
> How about using ENODATA here?  EINVAL tends to be used for lots of different
> reasons, and it's not always clear what it means.
>
> Note that FS_IOC_GET_ENCRYPTION_POLICY fails with ENODATA when called on an
> unencrypted file, which is a similar case.
>
> - Eric