lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Oct 2020 13:31:02 +0900 From: Namhyung Kim <namhyung@...nel.org> To: Alexey Budankov <alexey.budankov@...ux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@...nel.org>, Jiri Olsa <jolsa@...hat.com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Adrian Hunter <adrian.hunter@...el.com>, Andi Kleen <ak@...ux.intel.com>, Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 03/15] perf data: open data directory in read access mode On Thu, Oct 22, 2020 at 12:58 AM Alexey Budankov <alexey.budankov@...ux.intel.com> wrote: > > > Open files located at trace data directory in case read access > mode is requested. File are opened and its fds assigned to > perf_data dir files especially for loading data directories > content in perf report mode. > > Signed-off-by: Alexey Budankov <alexey.budankov@...ux.intel.com> > --- > tools/perf/util/data.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c > index c47aa34fdc0a..6ad61ac6ba67 100644 > --- a/tools/perf/util/data.c > +++ b/tools/perf/util/data.c > @@ -321,6 +321,10 @@ static int open_dir(struct perf_data *data) > return -1; > > ret = open_file(data); > + if (!ret && perf_data__is_dir(data)) { I think this __is_dir() check is unnecessary since it's checked from the caller side already. Thanks Namhyung > + if (perf_data__is_read(data)) > + ret = perf_data__open_dir(data); > + } > > /* Cleanup whatever we managed to create so far. */ > if (ret && perf_data__is_write(data)) > -- > 2.24.1 >
Powered by blists - more mailing lists