linux-kernel - Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dleftjzh4ezij0.fsf%l.stelmach@samsung.com>
Date:   Thu, 22 Oct 2020 12:01:23 +0200
From:   Lukasz Stelmach <l.stelmach@...sung.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v3 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet
 Adapter Driver

It was <2020-10-22 czw 09:15>, when Marek Szyprowski wrote:
> On 21.10.2020 23:49, Łukasz Stelmach wrote:
>> ASIX AX88796[1] is a versatile ethernet adapter chip, that can be
>> connected to a CPU with a 8/16-bit bus or with an SPI. This driver
>> supports SPI connection.
>>
>> The driver has been ported from the vendor kernel for ARTIK5[2]
>> boards. Several changes were made to adapt it to the current kernel
>> which include:
>>
>> + updated DT configuration,
>> + clock configuration moved to DT,
>> + new timer, ethtool and gpio APIs,
>> + dev_* instead of pr_* and custom printk() wrappers,
>> + removed awkward vendor power managemtn.
>>
>> [1] https://www.asix.com.tw/products.php?op=pItemdetail&PItemID=104;65;86&PLine=65
>> [2] https://git.tizen.org/cgit/profile/common/platform/kernel/linux-3.10-artik/
>>
>> The other ax88796 driver is for NE2000 compatible AX88796L chip. These
>> chips are not compatible. Hence, two separate drivers are required.
>>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
>
> coś zaszalałeś, jak dobry koreański kod - push bez kompilacji ;)
>
> drivers/net/ethernet/asix/ax88796c_main.c:758:13: error: static 
> declaration of ‘ax88796c_set_csums’ follows non-static declaration
>   static void ax88796c_set_csums(struct ax88796c_device *ax_local)
>               ^
> In file included from drivers/net/ethernet/asix/ax88796c_main.c:12:0:
> drivers/net/ethernet/asix/ax88796c_ioctl.h:24:6: note: previous 
> declaration of ‘ax88796c_set_csums’ was here
>   void ax88796c_set_csums(struct ax88796c_device *ax_local);
>        ^
> scripts/Makefile.build:283: recipe for target 
> 'drivers/net/ethernet/asix/ax88796c_main.o' failed
> make[4]: *** [drivers/net/ethernet/asix/ax88796c_main.o] Error 1
> scripts/Makefile.build:500: recipe for target 
> 'drivers/net/ethernet/asix' failed
> make[3]: *** [drivers/net/ethernet/asix] Error 2
> scripts/Makefile.build:500: recipe for target 'drivers/net/ethernet' failed
> make[2]: *** [drivers/net/ethernet] Error 2
> scripts/Makefile.build:500: recipe for target 'drivers/net' failed
> make[1]: *** [drivers/net] Error 2


Fixed. Thanks.

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

Download attachment "signature.asc" of type "application/pgp-signature" (488 bytes)