linux-kernel - Re: [PATCH v1 1/5] seq_file: Introduce DEFINE_STORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201022142213.GC4077@smile.fi.intel.com>
Date:   Thu, 22 Oct 2020 17:22:13 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Luo Jiaxing <luojiaxing@...wei.com>
Cc:     akpm@...ux-foundation.org, viro@...iv.linux.org.uk,
        linux-kernel@...r.kernel.org, martin.petersen@...cle.com,
        john.garry@...wei.com, himanshu.madhani@...ium.com,
        felipe.balbi@...ux.intel.com, gregkh@...uxfoundation.org,
        uma.shankar@...el.com, anshuman.gupta@...el.com,
        animesh.manna@...el.com, linux-usb@...r.kernel.org,
        linux-scsi@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH v1 1/5] seq_file: Introduce DEFINE_STORE_ATTRIBUTE()
 helper macro

On Thu, Oct 22, 2020 at 04:39:53PM +0800, Luo Jiaxing wrote:
> We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute
> for read-only file, but we found many of drivers want a helper marco for
> read-write file too.

I would expect that DEFINE_STORE maps to WO attribute...
For RW SHOW_STORE would be more appropriate.

Otherwise I think it makes sense.

-- 
With Best Regards,
Andy Shevchenko