linux-kernel - Re: [PATCH 1/2] PCI: export pci_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201022152148.GA23673@infradead.org>
Date:   Thu, 22 Oct 2020 16:21:48 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Zhenzhong Duan <zhenzhong.duan@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        bhelgaas@...gle.com
Subject: Re: [PATCH 1/2] PCI: export pci_match_device()

On Wed, Oct 21, 2020 at 04:10:29PM +0800, Zhenzhong Duan wrote:
> pci_match_id() is deprecated as it doesn't catch any dynamic ids that
> a driver might want to check for.
> 
> Export pci_match_device() as a replacement which supports both dynamic
> and static ids.

You don't actually seems to add any user outside of the PCI core,
so I think you only need to drop the static specifier and add a
prototype.