linux-kernel - Re: [PATCH 1/2] PCI: export pci_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFH1YnNQ5fL3TFQg_UqcFH6-fgmR8ZN9WkFUF9ZWNtb8k6zvvA@mail.gmail.com>
Date:   Mon, 26 Oct 2020 10:52:10 +0800
From:   Zhenzhong Duan <zhenzhong.duan@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH 1/2] PCI: export pci_match_device()

On Thu, Oct 22, 2020 at 11:21 PM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Wed, Oct 21, 2020 at 04:10:29PM +0800, Zhenzhong Duan wrote:
> > pci_match_id() is deprecated as it doesn't catch any dynamic ids that
> > a driver might want to check for.
> >
> > Export pci_match_device() as a replacement which supports both dynamic
> > and static ids.
>
> You don't actually seems to add any user outside of the PCI core,
> so I think you only need to drop the static specifier and add a
> prototype.
Thanks for review, will do it. I'll combine the two patches into one
if no need to export.