linux-kernel - Re: [PATCH 1/2] arm64: dts: renesas: hihope-common: Add optee node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8sEmC7oDdtc7tgK8D47P=V-tW8PExqpJkwU6=tZ6tb_dg@mail.gmail.com>
Date:   Fri, 23 Oct 2020 11:03:28 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Magnus Damm <magnus.damm@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Biju Das <biju.das.jz@...renesas.com>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: hihope-common: Add optee node

Hi Geert,

Thank you for the review.

On Fri, Oct 23, 2020 at 10:50 AM Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Fri, Oct 23, 2020 at 9:56 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> > Add optee device tree node to HiHope RZ/G2{HMN} boards.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@...renesas.com>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -110,6 +110,13 @@
> >                 #clock-cells = <0>;
> >                 clock-frequency = <25000000>;
> >         };
> > +
> > +       firmware {
> > +               optee {
> > +                       compatible = "linaro,optee-tz";
> > +                       method = "smc";
> > +               };
> > +       };
> >  };
>
> Should this be added to the SoC-specific .dtsi instead?
It's a bit tricky, the reason I put in board files is due to current
boards having optee do the same. Let me know if you want me to move
the nodes to SoC dtsi

> How can we test this?
This needs a special TFA (by special I mean optee enabled
(SPD="opteed")) and In Linux we need the below configs enabled:

CONFIG_TEE=y
CONFIG_OPTEE=y
CONFIG_OPTEE_SHM_NUM_PRIV_PAGES=1

Once Linux is booted up this exposes a optee device which can be used
for communication. I have used optee_test [1] test-suite (xtest) to
make sure all the tests pass (I have attached results for RZ/G2H for
reference).

[1] https://optee.readthedocs.io/en/latest/building/gits/optee_test.html

Cheers,
Prabhakar
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds

View attachment "rzg2h.txt" of type "text/plain" (165900 bytes)