linux-kernel - Re: [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Oct 2020 13:32:04 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, Jaroslav Kysela <perex@...ex.cz>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        Harsha Priya <harshapriya.n@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        alsa-devel@...a-project.org (moderated list:SOUND),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 1/4] ALSA: hda: Refactor codec PM to use direct-complete optimization

On Fri, 23 Oct 2020 12:23:35 +0200,
Kai-Heng Feng wrote:
> 
> +static void hda_codec_pm_complete(struct device *dev)
>  {
>  	struct hda_codec *codec = dev_to_hda_codec(dev);
> -	int ret;
>  
> -	ret = pm_runtime_force_resume(dev);
> -	/* schedule jackpoll work for jack detection update */
> -	if (codec->jackpoll_interval ||
> -	    (pm_runtime_suspended(dev) && hda_codec_need_resume(codec)))
> -		schedule_delayed_work(&codec->jackpoll_work,
> -				      codec->jackpoll_interval);
> -	return ret;
> +	if (pm_runtime_suspended(dev) &&
> +	    (hda_codec_need_resume(codec) || codec->forced_resume))
> +		pm_request_resume(dev);

You shouldn't drop the check of codec->jackpoll_interval.  If this
field is set, the codec driver has to resume no matter what it was, so
that the polling can start up again.


thanks,

Takashi