linux-kernel - Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5himb189by.wl-tiwai@suse.de>
Date:   Fri, 23 Oct 2020 13:34:25 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     tiwai@...e.com, Jaroslav Kysela <perex@...ex.cz>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Alex Deucher <alexander.deucher@....com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        alsa-devel@...a-project.org (moderated list:SOUND),
        linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH 2/4] ALSA: hda: Stop mangling PCI MSI

On Fri, 23 Oct 2020 12:23:36 +0200,
Kai-Heng Feng wrote:
> 
> @@ -1038,14 +1036,6 @@ static int azx_suspend(struct device *dev)
>  		__azx_runtime_suspend(chip);
>  	else
>  		pm_runtime_force_suspend(dev);
> -	if (bus->irq >= 0) {
> -		free_irq(bus->irq, chip);
> -		bus->irq = -1;
> -		chip->card->sync_irq = -1;
> -	}

This release of irq has nothing to do with MSI.  There has been PCI
controllers that assign to a different IRQ line after the resume.

> -	if (azx_acquire_irq(chip, 1) < 0)
> -		return -EIO;

Ditto.


thanks,

Takashi