linux-kernel - Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <53199cd1-772c-f30e-4f74-93572d6875cb@gmail.com>
Date:   Sun, 25 Oct 2020 19:30:11 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     lukasz.luba@....com, enric.balletbo@...labora.com,
        hl@...k-chips.com, thierry.reding@...il.com, jonathanh@...dia.com,
        abel.vesa@....com, k.konieczny@...sung.com,
        b.zolnierkie@...sung.com, chanwoo@...nel.org,
        myungjoo.ham@...sung.com, kyungmin.park@...sung.com
Subject: Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for
 specifc sysfs nodes

23.10.2020 13:26, Chanwoo Choi пишет:
> @@ -909,6 +915,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
>  		goto err_init;
>  	}
>  
> +	create_sysfs_files(devfreq, governor);
> +
>  	devfreq->governor = governor;
>  	err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>  						NULL);

Shouldn't sysfs be created *after* GOV_START? This is inconsistent with
governor_store().