linux-kernel - Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a2c99d1-ef65-4d89-3740-90a3b60d4cd5@gmail.com>
Date:   Sun, 25 Oct 2020 19:31:09 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Chanwoo Choi <cw00.choi@...sung.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     lukasz.luba@....com, enric.balletbo@...labora.com,
        hl@...k-chips.com, thierry.reding@...il.com, jonathanh@...dia.com,
        abel.vesa@....com, k.konieczny@...sung.com,
        b.zolnierkie@...sung.com, chanwoo@...nel.org,
        myungjoo.ham@...sung.com, kyungmin.park@...sung.com
Subject: Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for
 specifc sysfs nodes

23.10.2020 13:26, Chanwoo Choi пишет:
> @@ -1401,8 +1423,13 @@ static ssize_t governor_store(struct device *dev, struct device_attribute *attr,
>  				"%s: reverting to Governor %s failed (%d)\n",
>  				__func__, df->governor_name, ret);
>  			df->governor = NULL;
> +			goto out;
>  		}
...
> +		create_sysfs_files(df, df->governor);
> +		goto out;

These two lines could be removed.

>  	}
> +	create_sysfs_files(df, df->governor);
> +
>  out:
>  	mutex_unlock(&devfreq_list_lock);

Otherwise looks good to me.

Reviewed-by: Dmitry Osipenko <digetx@...il.com>
Tested-by: Dmitry Osipenko <digetx@...il.com>