linux-kernel - Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd3c09d-a55d-318c-afc6-88a2215110e1@samsung.com>
Date:   Mon, 26 Oct 2020 11:02:23 +0900
From:   Chanwoo Choi <cw00.choi@...sung.com>
To:     Dmitry Osipenko <digetx@...il.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     lukasz.luba@....com, enric.balletbo@...labora.com,
        hl@...k-chips.com, thierry.reding@...il.com, jonathanh@...dia.com,
        abel.vesa@....com, k.konieczny@...sung.com,
        b.zolnierkie@...sung.com, chanwoo@...nel.org,
        myungjoo.ham@...sung.com, kyungmin.park@...sung.com
Subject: Re: [PATCH v5 2/2] PM / devfreq: Add governor attribute flag for
 specifc sysfs nodes

On 10/26/20 1:30 AM, Dmitry Osipenko wrote:
> 23.10.2020 13:26, Chanwoo Choi пишет:
>> @@ -909,6 +915,8 @@ struct devfreq *devfreq_add_device(struct device *dev,
>>  		goto err_init;
>>  	}
>>  
>> +	create_sysfs_files(devfreq, governor);
>> +
>>  	devfreq->governor = governor;
>>  	err = devfreq->governor->event_handler(devfreq, DEVFREQ_GOV_START,
>>  						NULL);
> 
> Shouldn't sysfs be created *after* GOV_START? This is inconsistent with
> governor_store().
> 
> 

Good point. Thanks for the review. I'll edit it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics