linux-kernel - Re: [PATCH] ALSA: make snd_kcontrol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Oct 2020 20:03:39 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        ALSA Development Mailing List <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: make snd_kcontrol_new name a normal string

On Mon, Oct 26, 2020 at 6:03 PM Takashi Iwai <tiwai@...e.de> wrote:
> On Mon, 26 Oct 2020 17:52:18 +0100,
> Arnd Bergmann wrote:
> >
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > When building with W=2, there are lots of warnings about the
> > snd_kcontrol_new name field being an array of 'unsigned char'
> > but initialized to a string:
> >
> > include/sound/soc.h:93:48: warning: pointer targets in initialization of 'const unsigned char *' from 'char *' differ in signedness [-Wpointer-sign]
> >
> > Make it a regular 'char *' to avoid flooding the build log with this.
> >
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> I'm fine to apply this, but I thought we agreed to ignore pointer
> signedness intentionally?  There are lots of such places and we were
> fed up in the past when gcc complained a lot about those...

I'm only sending fixes for the ones in headers that get included in
a lot of places. There are good reasons for building being able to
build specific drivers or directories with W=2, but it's less helpful
if there are many identical warnings.

       Arnd