linux-kernel - Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201026190406.GL858@sol.localdomain>
Date:   Mon, 26 Oct 2020 12:04:06 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     Daeho Jeong <daeho43@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, kernel-team@...roid.com,
        Daeho Jeong <daehojeong@...gle.com>
Subject: Re: [PATCH v3 1/2] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION ioctl

On Mon, Oct 26, 2020 at 01:16:55PM +0900, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@...gle.com>
> 
> Added a new F2FS_IOC_GET_COMPRESS_OPTION ioctl to get file compression
> option of a file.
> 
> struct f2fs_comp_option {
>     u8 algorithm;         => compression algorithm
>                           => 0:lzo, 1:lz4, 2:zstd, 3:lzorle
>     u8 log_cluster_size;  => log scale cluster size
>                           => 2 ~ 8
> };
> 
> struct f2fs_comp_option option;
> 
> ioctl(fd, F2FS_IOC_GET_COMPRESS_OPTION, &option);
> 
> Signed-off-by: Daeho Jeong <daehojeong@...gle.com>
> Reviewed-by: Eric Biggers <ebiggers@...nel.org>

Please don't add Reviewed-by until it is explicitly given.

The actual code looks fine, but there's still no mention of documentation,
tests, or use cases.

- Eric