linux-kernel - RE: [PATCH v3] usb: cdns3: Variable 'length' set but not used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR07MB55290EA090C418457C1E293BDD190@DM6PR07MB5529.namprd07.prod.outlook.com>
Date:   Mon, 26 Oct 2020 09:47:36 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     "peter.chen@....com" <peter.chen@....com>
CC:     "balbi@...nel.org" <balbi@...nel.org>,
        "rogerq@...com" <rogerq@...com>, "nsekhar@...com" <nsekhar@...com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rahul Kumar <kurahul@...ence.com>
Subject: RE: [PATCH v3] usb: cdns3: Variable 'length' set but not used

Hi Peter,

A gentle ping.

I assume that you should add this and the rest overdue cdsn3 patches as first to you ci-for-usb-next branch.
Am I right?

Pawel

>Patch removes not used variable 'length' from
>cdns3_wa2_descmiss_copy_data function.
>
>Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case")
>Signed-off-by: Pawel Laszczak <pawell@...ence.com>
>Acked-by: Roger Quadros <rogerq@...com>
>---
>Changelog:
>v3
>- added "Acked-by" tag.
>v2
>- added "Fixes" tag.
>
> drivers/usb/cdns3/gadget.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
>index 6e7b70a2e352..692acf7b9b14 100644
>--- a/drivers/usb/cdns3/gadget.c
>+++ b/drivers/usb/cdns3/gadget.c
>@@ -506,7 +506,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
>
> 	while (!list_empty(&priv_ep->wa2_descmiss_req_list)) {
> 		int chunk_end;
>-		int length;
>
> 		descmiss_priv_req =
> 			cdns3_next_priv_request(&priv_ep->wa2_descmiss_req_list);
>@@ -517,7 +516,6 @@ static void cdns3_wa2_descmiss_copy_data(struct cdns3_endpoint *priv_ep,
> 			break;
>
> 		chunk_end = descmiss_priv_req->flags & REQUEST_INTERNAL_CH;
>-		length = request->actual + descmiss_req->actual;
> 		request->status = descmiss_req->status;
> 		__cdns3_descmiss_copy_data(request, descmiss_req);
> 		list_del_init(&descmiss_priv_req->list);
>--
>2.17.1