linux-kernel - RE: [PATCH v2] usb: cdns3: Add static to cdns3_gadget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR07MB5529FAECD9AEF3A82B20B677DD190@DM6PR07MB5529.namprd07.prod.outlook.com>
Date:   Mon, 26 Oct 2020 09:47:38 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     Pawel Laszczak <pawell@...ence.com>,
        "peter.chen@....com" <peter.chen@....com>
CC:     "balbi@...nel.org" <balbi@...nel.org>,
        "rogerq@...com" <rogerq@...com>, "nsekhar@...com" <nsekhar@...com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rahul Kumar <kurahul@...ence.com>
Subject: RE: [PATCH v2] usb: cdns3: Add static to cdns3_gadget_exit function


>Function cdns3_gadget_exit is used only in gadget.c file.
>This patch removes declaration and definition of this
>function from gadget-export.h file and makes it static.
>
>Signed-off-by: Pawel Laszczak <pawell@...ence.com>
>Acked-by: Roger Quadros <rogerq@...com>
>---
>Changelog:
>v2
>- added "Ackded-by" tag.
>
> drivers/usb/cdns3/gadget-export.h | 3 ---
> drivers/usb/cdns3/gadget.c        | 2 +-
> 2 files changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/drivers/usb/cdns3/gadget-export.h b/drivers/usb/cdns3/gadget-export.h
>index 577469eee961..702c5a267a92 100644
>--- a/drivers/usb/cdns3/gadget-export.h
>+++ b/drivers/usb/cdns3/gadget-export.h
>@@ -13,7 +13,6 @@
> #ifdef CONFIG_USB_CDNS3_GADGET
>
> int cdns3_gadget_init(struct cdns3 *cdns);
>-void cdns3_gadget_exit(struct cdns3 *cdns);
> #else
>
> static inline int cdns3_gadget_init(struct cdns3 *cdns)
>@@ -21,8 +20,6 @@ static inline int cdns3_gadget_init(struct cdns3 *cdns)
> 	return -ENXIO;
> }
>
>-static inline void cdns3_gadget_exit(struct cdns3 *cdns) { }
>-
> #endif
>
> #endif /* __LINUX_CDNS3_GADGET_EXPORT */
>diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
>index 692acf7b9b14..6ff3aa3db497 100644
>--- a/drivers/usb/cdns3/gadget.c
>+++ b/drivers/usb/cdns3/gadget.c
>@@ -3069,7 +3069,7 @@ static void cdns3_gadget_release(struct device *dev)
> 	kfree(priv_dev);
> }
>
>-void cdns3_gadget_exit(struct cdns3 *cdns)
>+static void cdns3_gadget_exit(struct cdns3 *cdns)
> {
> 	struct cdns3_device *priv_dev;
>
>--
>2.17.1