lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 26 Oct 2020 16:36:13 +0100 From: Hans de Goede <hdegoede@...hat.com> To: "Limonciello, Mario" <Mario.Limonciello@...l.com>, Divya Bharathi <divya27392@...il.com>, "dvhart@...radead.org" <dvhart@...radead.org> Cc: LKML <linux-kernel@...r.kernel.org>, "platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>, "Bharathi, Divya" <Divya.Bharathi@...l.com>, Andy Shevchenko <andy.shevchenko@...il.com>, mark gross <mgross@...ux.intel.com>, "Ksr, Prasanth" <Prasanth.Ksr@...l.com> Subject: Re: [PATCH v6] Introduce support for Systems Management Driver over WMI for Dell Systems Hi, On 10/26/20 4:25 PM, Limonciello, Mario wrote: >>> + >>> + print_hex_dump_bytes("set attribute data: ", DUMP_PREFIX_NONE, buffer, >> buffer_size); >> >> This seems to be a debugging left-over? > > Yes it was for debugging, but its configurable to turn on by dynamic > debug as I can tell. Is that not correct? Since it does not have debug in its name I sorta assumed it would always do the print. But you are right, this is a shorthand macro for print_hex_dump_debug() (which takes a few more arguments), so this only dumps the buffer when debugging is enabled. IOW keeping this "as is" is fine, sorry for the noise. Regards, Has
Powered by blists - more mailing lists