linux-kernel - RE: [PATCH v6] Introduce support for Systems Management Driver over WMI for Dell Systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR19MB26367BCFE51C45BC00D13F6BFA190@DM6PR19MB2636.namprd19.prod.outlook.com>
Date:   Mon, 26 Oct 2020 15:39:34 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@...l.com>
To:     Hans de Goede <hdegoede@...hat.com>,
        Divya Bharathi <divya27392@...il.com>,
        "dvhart@...radead.org" <dvhart@...radead.org>
CC:     LKML <linux-kernel@...r.kernel.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>,
        "Bharathi, Divya" <Divya.Bharathi@...l.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        mark gross <mgross@...ux.intel.com>,
        "Ksr, Prasanth" <Prasanth.Ksr@...l.com>
Subject: RE: [PATCH v6] Introduce support for Systems Management Driver over
 WMI for Dell Systems

> This was present in previous versions too, but I just noticed this are you
> sure that using
> .string.pointer is correct here? That seems wrong since the pointer gets
> allocated by
> the Linux ACPI core, so it is not under influence of the AML code?
> 
> I think you want / need to use ".integer.value" here ?
> 
> And maybe first do a type check, e.g.:
> 
> 	if (obj->package.elements[CURRENT_VAL].type != ACPI_TYPE_INTEGER) {
> 		ret = -EINVAL;
> 		goto out;
> 	}
> 
> Adding this type check will also show if I'm right that you should use
> .integer.value ...
> 
> 	ret = snprintf(buf, PAGE_SIZE, "%lld\n", obj-

We'll need to double check this, but I'm pretty sure the firmware outputs
everything as a string.