linux-kernel - Re: [PATCH v3 2/2] x86/resctrl: Correct MBM total and local values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201027180256.GA3478584@otcwcpicx6.sc.intel.com>
Date:   Tue, 27 Oct 2020 18:02:56 +0000
From:   Fenghua Yu <fenghua.yu@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Stephane Eranian <eranian@...gle.com>,
        Tony Luck <tony.luck@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Ravi V Shankar <ravi.v.shankar@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: Re: [PATCH v3 2/2] x86/resctrl: Correct MBM total and local values

Hi, Boris,

On Tue, Oct 27, 2020 at 06:57:48PM +0100, Borislav Petkov wrote:
> On Wed, Oct 14, 2020 at 12:49:27AM +0000, Fenghua Yu wrote:
> > +static const struct mbm_correction_factor_table {
> > +	u32 rmidthreshold;
> > +	u64 cf;
> > +} mbm_cf_table[] = {
> 
> That thing wants to be __initdata, AFAICT, since the only function
> touching it is __init.
> 
> Made it so.

You are right. The correction value is read from this table only
once in __init. So this table should be __initdata.

Thank you very much for your review!

-Fenghua