linux-kernel - Re: [PATCH AUTOSEL 4.19 08/60] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Oct 2020 10:59:43 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     Zejiang Tang <tangzejiang@...ngson.cn>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 08/60] MIPS: ftrace: Remove redundant #ifdef
 CONFIG_DYNAMIC_FTRACE

Hello!

On 27.10.2020 3:03, Sasha Levin wrote:

> From: Zejiang Tang <tangzejiang@...ngson.cn>
> 
> [ Upstream commit 39116103a7345927fa99644d08bc0cc9d45fea6f ]
> 
> There exists redundant #ifdef CONFIG_DYNAMIC_FTRACE in ftrace.c, remove it.
> 
> Signed-off-by: Zejiang Tang <tangzejiang@...ngson.cn>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>   arch/mips/kernel/ftrace.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
> index b122cbb4aad18..7dd52da55907f 100644
> --- a/arch/mips/kernel/ftrace.c
> +++ b/arch/mips/kernel/ftrace.c
> @@ -37,10 +37,6 @@ void arch_ftrace_update_code(int command)
>   	ftrace_modify_all_code(command);
>   }
>   
> -#endif
> -
> -#ifdef CONFIG_DYNAMIC_FTRACE
> -
>   #define JAL 0x0c000000		/* jump & link: ip --> ra, jump to target */
>   #define ADDR_MASK 0x03ffffff	/*  op_code|addr : 31...26|25 ....0 */
>   #define JUMP_RANGE_MASK ((1UL << 28) - 1)

    Are you sure this is neccessary in -stable? What bug does it fix?

MBR, Sergei