linux-kernel - Re: [PATCH AUTOSEL 4.19 28/60] riscv: Define AT_VECTOR_SIZE_ARCH for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 05 Nov 2020 21:26:40 -0800 (PST)
From:   Palmer Dabbelt <palmerdabbelt@...gle.com>
To:     sashal@...nel.org
CC:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        zong.li@...ive.com, penberg@...nel.org, sashal@...nel.org,
        linux-riscv@...ts.infradead.org
Subject:     Re: [PATCH AUTOSEL 4.19 28/60] riscv: Define AT_VECTOR_SIZE_ARCH for ARCH_DLINFO

On Mon, 26 Oct 2020 17:03:43 PDT (-0700), sashal@...nel.org wrote:
> From: Zong Li <zong.li@...ive.com>
>
> [ Upstream commit b5fca7c55f9fbab5ad732c3bce00f31af6ba5cfa ]
>
> AT_VECTOR_SIZE_ARCH should be defined with the maximum number of
> NEW_AUX_ENT entries that ARCH_DLINFO can contain, but it wasn't defined
> for RISC-V at all even though ARCH_DLINFO will contain one NEW_AUX_ENT
> for the VDSO address.
>
> Signed-off-by: Zong Li <zong.li@...ive.com>
> Reviewed-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> Reviewed-by: Pekka Enberg <penberg@...nel.org>
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@...gle.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  arch/riscv/include/uapi/asm/auxvec.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/arch/riscv/include/uapi/asm/auxvec.h b/arch/riscv/include/uapi/asm/auxvec.h
> index 1376515547cda..ed7bf7c7add5f 100644
> --- a/arch/riscv/include/uapi/asm/auxvec.h
> +++ b/arch/riscv/include/uapi/asm/auxvec.h
> @@ -21,4 +21,7 @@
>  /* vDSO location */
>  #define AT_SYSINFO_EHDR 33
>
> +/* entries in ARCH_DLINFO */
> +#define AT_VECTOR_SIZE_ARCH	1
> +
>  #endif /* _UAPI_ASM_RISCV_AUXVEC_H */

Thanks.  This should have been

Fixes: 2129a235c098 ("RISC-V: ELF and module implementation")

which is essentially all the way back to the beginning.