linux-kernel - Re: [PATCH 2/6] kselftest/arm64: Fix check_tags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4783a06c-f9a1-73fa-9cf3-73f8e258989d@arm.com>
Date:   Tue, 27 Oct 2020 15:57:06 +0530
From:   Amit Kachhap <amit.kachhap@....com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Gabor Kertesz <gabor.kertesz@....com>
Subject: Re: [PATCH 2/6] kselftest/arm64: Fix check_tags_inclusion test



On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_tags_inclusion test reports the error below because the test
> plan is not declared correctly:
> 
>    # Planned tests != run tests (0 != 4)
> 
> Fix the test adding the correct test plan declaration.

This change is required and got missed earlier.
Acked by: Amit Daniel Kachhap <amit.kachhap@....com>

> 
> Fixes: f3b2a26ca78d ("kselftest/arm64: Verify mte tag inclusion via prctl")
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Gabor Kertesz <gabor.kertesz@....com>
> Cc: Amit Daniel Kachhap <amit.kachhap@....com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> ---
>   tools/testing/selftests/arm64/mte/check_tags_inclusion.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/tools/testing/selftests/arm64/mte/check_tags_inclusion.c b/tools/testing/selftests/arm64/mte/check_tags_inclusion.c
> index 94d245a0ed56..deaef1f61076 100644
> --- a/tools/testing/selftests/arm64/mte/check_tags_inclusion.c
> +++ b/tools/testing/selftests/arm64/mte/check_tags_inclusion.c
> @@ -170,6 +170,9 @@ int main(int argc, char *argv[])
>   	/* Register SIGSEGV handler */
>   	mte_register_signal(SIGSEGV, mte_default_handler);
>   
> +	/* Set test plan */
> +	ksft_set_plan(4);
> +
>   	evaluate_test(check_single_included_tags(USE_MMAP, MTE_SYNC_ERR),
>   		      "Check an included tag value with sync mode\n");
>   	evaluate_test(check_multiple_included_tags(USE_MMAP, MTE_SYNC_ERR),
>