linux-kernel - Re: [PATCH 4/6] kselftest/arm64: Fix check_mmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a719ad9-0eef-5f7a-be5a-f2194d774d74@arm.com>
Date:   Tue, 27 Oct 2020 16:01:16 +0530
From:   Amit Kachhap <amit.kachhap@....com>
To:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Gabor Kertesz <gabor.kertesz@....com>
Subject: Re: [PATCH 4/6] kselftest/arm64: Fix check_mmap_options test



On 10/26/20 5:42 PM, Vincenzo Frascino wrote:
> The check_mmap_options test reports the error below because the test
> plan is not declared correctly:
> 
>    # Planned tests != run tests (0 != 22)
> 
> Fix the test adding the correct test plan declaration.

This change is required and got missed earlier.
Acked by: Amit Daniel Kachhap <amit.kachhap@....com>

> 
> Fixes: 53ec81d23213 ("kselftest/arm64: Verify all different mmap MTE options")
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Catalin Marinas <catalin.marinas@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Gabor Kertesz <gabor.kertesz@....com>
> Cc: Amit Daniel Kachhap <amit.kachhap@....com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> ---
>   tools/testing/selftests/arm64/mte/check_mmap_options.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/selftests/arm64/mte/check_mmap_options.c b/tools/testing/selftests/arm64/mte/check_mmap_options.c
> index 33b13b86199b..a04b12c21ac9 100644
> --- a/tools/testing/selftests/arm64/mte/check_mmap_options.c
> +++ b/tools/testing/selftests/arm64/mte/check_mmap_options.c
> @@ -205,7 +205,11 @@ int main(int argc, char *argv[])
>   	mte_register_signal(SIGBUS, mte_default_handler);
>   	mte_register_signal(SIGSEGV, mte_default_handler);
>   
> +	/* Set test plan */
> +	ksft_set_plan(22);
> +
>   	mte_enable_pstate_tco();
> +
>   	evaluate_test(check_anonymous_memory_mapping(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE, TAG_CHECK_OFF),
>   	"Check anonymous memory with private mapping, sync error mode, mmap memory and tag check off\n");
>   	evaluate_test(check_file_memory_mapping(USE_MPROTECT, MTE_SYNC_ERR, MAP_PRIVATE, TAG_CHECK_OFF),
>