linux-kernel - Re: [PATCH v2] mm/slub: fix panic in slab_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <73aa614f-24e6-75d5-8173-d858a5b33fec@linux.ibm.com>
Date:   Wed, 28 Oct 2020 14:49:45 +0100
From:   Laurent Dufour <ldufour@...ux.ibm.com>
To:     Christopher Lameter <cl@...ux.com>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        nathanl@...ux.ibm.com, cheloha@...ux.ibm.com, mhocko@...e.com,
        Vlastimil Babka <vbabka@...e.cz>,
        Pekka Enberg <penberg@...nel.org>,
        David Rientjes <rientjes@...gle.com>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH v2] mm/slub: fix panic in slab_alloc_node()

Le 28/10/2020 à 12:11, Christopher Lameter a écrit :
> On Tue, 27 Oct 2020, Laurent Dufour wrote:
> 
>> The issue is that object is not NULL while page is NULL which is odd but
>> may happen if the cache flush happened after loading object but before
>> loading page. Thus checking for the page pointer is required too.
> 
> 
> Ok then lets revert commit  6159d0f5c03e? The situation may occur
> elsewhere too.

The only other call to node_match() is in ___slab_alloc(), and the page pointer 
is already checked there.
So there is no real need to check it in node_match().