lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Oct 2020 05:10:49 +0000 From: Joel Stanley <joel@....id.au> To: Billy Tsai <billy_tsai@...eedtech.com> Cc: Rob Herring <robh+dt@...nel.org>, Andrew Jeffery <andrew@...id.au>, devicetree <devicetree@...r.kernel.org>, Linux ARM <linux-arm-kernel@...ts.infradead.org>, linux-aspeed <linux-aspeed@...ts.ozlabs.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <bgolaszewski@...libre.com>, "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>, OpenBMC Maillist <openbmc@...ts.ozlabs.org>, BMC-SW <BMC-SW@...eedtech.com> Subject: Re: [PATCH 2/3] Arm: dts: aspeed-g6: Add sgpio node On Mon, 12 Oct 2020 at 04:56, Billy Tsai <billy_tsai@...eedtech.com> wrote: > > Hi Joel, > > Thanks for the review. > > On 2020/10/12, 12:35 PM, Joel Stanley wrote: > > > On Mon, 12 Oct 2020 at 03:32, Billy Tsai <billy_tsai@...eedtech.com> wrote: > > > > > > This patch is used to add sgpiom and sgpios nodes and add compatible > > > string for sgpiom. > > > > You also need to add sgpios documentation to the bindings docs. > > > > Whenever you add new device tree bindings to the kernel tree you > > should add documentation for them. > > > > When preparing patches for submission, use scripts/checkpatch.pl to > > check for common issues. It will warn you if you are adding strings > > that are not documented. > > > > Cheers, > > > > Joel > > > Because the driver of sgpios doesn't be implemented, so I don't know how to describe it at sgpio-aspeed.txt. > Can I just add compatible string " aspeed,ast2600-sgpios " to the document for bypassing the warning of checkpatch? Ignore the sgpios issue for now; we don't have a driver for it so there's no need to add strings. Drop that part from your dts patch. > > > > > > - compatible : Should be one of > > > - "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio" > > > + "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio", "aspeed,ast2600-sgpiom" > > > > I think we should add sgpiom strings for the ast2500 (and ast2400?) > > too, as this is how they should have been named in the first place: > > > If I change the document whether I also need to send the patch for sgpio driver and g5/g4.dtsi? For the sgpiom? We already have a driver for that. As I said above, make this about fixing the sgpio master and put aside the sgpio slave issue for now. Cheers, Joel > > > - compatible : Should be one of > > > "aspeed,ast2400-sgpio", "aspeed,ast2500-sgpio" > > > "aspeed,ast2400-sgpiom", "aspeed,ast2500-sgpiom", "aspeed,ast2600-sgpiom"
Powered by blists - more mailing lists