linux-kernel - Re: [PATCH] arm64: dts: imx8mm: Add support for micfil

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHCN7xKBx_YXCGSUJWO3YCaGfx4oc7iuv6S4qi500_NjV9pW=w@mail.gmail.com>
Date:   Wed, 28 Oct 2020 07:10:37 -0500
From:   Adam Ford <aford173@...il.com>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     arm-soc <linux-arm-kernel@...ts.infradead.org>,
        aford@...conemedded.com, Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mm: Add support for micfil

On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@...nel.org> wrote:
>
> On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote:
> > The i.MX8M Mini has supports the MICFIL digital interface.
> > It's a 16-bit audio signal from a PDM microphone bitstream.
> > The driver is already in the kernel, but the node is missing.
> >
> > This patch adds the micfil node.
> >
> > Signed-off-by: Adam Ford <aford173@...il.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index c63685ae80ee..d46e727fc362 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -339,6 +339,25 @@ sai6: sai@...60000 {
> >                               status = "disabled";
> >                       };
> >
> > +                     micfil: micfil@...80000 {
>
> Find a generic node name, audio-controller maybe?

The SAI's nodes are called SAI@...x

If that's a deal-breaker, I can push a V3.

I didn't see anyone from the device tree side comment, and the device
tree binding doc states 'micfil@...xxx' so I used what was documented
in the fsl,micfil.txt

adam
>
> Shawn
>
> > +                             compatible = "fsl,imx8mm-micfil";
> > +                             reg = <0x30080000 0x10000>;
> > +                             interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> > +                                          <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
> > +                                          <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
> > +                                          <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> > +                             clocks = <&clk IMX8MM_CLK_PDM_IPG>,
> > +                                      <&clk IMX8MM_CLK_PDM_ROOT>,
> > +                                      <&clk IMX8MM_AUDIO_PLL1_OUT>,
> > +                                      <&clk IMX8MM_AUDIO_PLL2_OUT>,
> > +                                      <&clk IMX8MM_CLK_EXT3>;
> > +                             clock-names = "ipg_clk", "ipg_clk_app",
> > +                                           "pll8k", "pll11k", "clkext3";
> > +                             dmas = <&sdma2 24 25 0x80000000>;
> > +                             dma-names = "rx";
> > +                             status = "disabled";
> > +                     };
> > +
> >                       gpio1: gpio@...00000 {
> >                               compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio";
> >                               reg = <0x30200000 0x10000>;
> > --
> > 2.25.1
> >