linux-kernel - Re: [PATCH] arm64: dts: imx8mm: Add support for micfil

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201029192436.GB308501@kozik-lap>
Date:   Thu, 29 Oct 2020 20:24:36 +0100
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Adam Ford <aford173@...il.com>
Cc:     Shawn Guo <shawnguo@...nel.org>,
        arm-soc <linux-arm-kernel@...ts.infradead.org>,
        aford@...conemedded.com, Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: imx8mm: Add support for micfil

On Wed, Oct 28, 2020 at 07:10:37AM -0500, Adam Ford wrote:
> On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@...nel.org> wrote:
> >
> > On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote:
> > > The i.MX8M Mini has supports the MICFIL digital interface.
> > > It's a 16-bit audio signal from a PDM microphone bitstream.
> > > The driver is already in the kernel, but the node is missing.
> > >
> > > This patch adds the micfil node.
> > >
> > > Signed-off-by: Adam Ford <aford173@...il.com>
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index c63685ae80ee..d46e727fc362 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -339,6 +339,25 @@ sai6: sai@...60000 {
> > >                               status = "disabled";
> > >                       };
> > >
> > > +                     micfil: micfil@...80000 {
> >
> > Find a generic node name, audio-controller maybe?
> 
> The SAI's nodes are called SAI@...x
> 
> If that's a deal-breaker, I can push a V3.
> 
> I didn't see anyone from the device tree side comment, and the device
> tree binding doc states 'micfil@...xxx' so I used what was documented
> in the fsl,micfil.txt

Hi,

The example in the binding is not a binding itself. It can be misleading
or even incorrect and it is not a reason to use such in DTS.

Could be also audio-codec but it is not accurate (as it is only from the
microphone to digital).

Shawn's proposal is the best, I think.

Best regards,
Krzysztof