linux-kernel - [PATCH -next] platform/surface: remove status assignment without reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1603972048-64271-1-git-send-email-zou_wei@huawei.com>
Date:   Thu, 29 Oct 2020 19:47:28 +0800
From:   Zou Wei <zou_wei@...wei.com>
To:     <hdegoede@...hat.com>, <mgross@...ux.intel.com>,
        <luzmaximilian@...il.com>
CC:     <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, "Zou Wei" <zou_wei@...wei.com>
Subject: [PATCH -next] platform/surface: remove status assignment without reading

The status local variable is assigned but never read:

drivers/platform/surface/surface3-wmi.c:60:14: warning:
variable ‘status’ set but not used [-Wunused-but-set-variable]
  acpi_status status;
              ^~~~~~

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Zou Wei <zou_wei@...wei.com>
---
 drivers/platform/surface/surface3-wmi.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/platform/surface/surface3-wmi.c b/drivers/platform/surface/surface3-wmi.c
index 130b6f5..ae1416c 100644
--- a/drivers/platform/surface/surface3-wmi.c
+++ b/drivers/platform/surface/surface3-wmi.c
@@ -57,12 +57,10 @@ static DEFINE_MUTEX(s3_wmi_lock);
 static int s3_wmi_query_block(const char *guid, int instance, int *ret)
 {
 	struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
-	acpi_status status;
 	union acpi_object *obj;
 	int error = 0;
 
 	mutex_lock(&s3_wmi_lock);
-	status = wmi_query_block(guid, instance, &output);
 
 	obj = output.pointer;
 
-- 
2.6.2