linux-kernel - Re: [PATCH -next] platform/surface: remove status assignment without reading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Ve64EvD7_H8h2MW39dpimWbPcANZC3-zgF__yA6C7BGQA@mail.gmail.com>
Date:   Thu, 29 Oct 2020 13:52:53 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Zou Wei <zou_wei@...wei.com>
Cc:     Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        Maximilian Luz <luzmaximilian@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] platform/surface: remove status assignment without reading

On Thu, Oct 29, 2020 at 1:36 PM Zou Wei <zou_wei@...wei.com> wrote:
>
> The status local variable is assigned but never read:

...

>         mutex_lock(&s3_wmi_lock);
> -       status = wmi_query_block(guid, instance, &output);

What are you doing?!


-- 
With Best Regards,
Andy Shevchenko