linux-kernel - Re: [PATCH v20 05/20] mm/thp: Simplify lru_add_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201029140020.GF599825@cmpxchg.org>
Date:   Thu, 29 Oct 2020 10:00:20 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Alex Shi <alex.shi@...ux.alibaba.com>
Cc:     akpm@...ux-foundation.org, mgorman@...hsingularity.net,
        tj@...nel.org, hughd@...gle.com, khlebnikov@...dex-team.ru,
        daniel.m.jordan@...cle.com, willy@...radead.org, lkp@...el.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        cgroups@...r.kernel.org, shakeelb@...gle.com,
        iamjoonsoo.kim@....com, richard.weiyang@...il.com,
        kirill@...temov.name, alexander.duyck@...il.com,
        rong.a.chen@...el.com, mhocko@...e.com, vdavydov.dev@...il.com,
        shy828301@...il.com,
        Mika Penttilä <mika.penttila@...tfour.com>
Subject: Re: [PATCH v20 05/20] mm/thp: Simplify lru_add_page_tail()

On Thu, Oct 29, 2020 at 06:44:50PM +0800, Alex Shi wrote:
> Simplify lru_add_page_tail(), there are actually only two cases possible:
> split_huge_page_to_list(), with list supplied and head isolated from lru
> by its caller; or split_huge_page(), with NULL list and head on lru -
> because when head is racily isolated from lru, the isolator's reference
> will stop the split from getting any further than its page_ref_freeze().
> 
> So decide between the two cases by "list", but add VM_WARN_ON()s to
> verify that they match our lru expectations.
> 
> [Hugh Dickins: rewrite commit log]
> Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
> Reviewed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> Acked-by: Hugh Dickins <hughd@...gle.com>
> Cc: Kirill A. Shutemov <kirill@...temov.name>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Matthew Wilcox <willy@...radead.org>
> Cc: Hugh Dickins <hughd@...gle.com>
> Cc: Mika Penttilä <mika.penttila@...tfour.com>
> Cc: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org

Acked-by: Johannes Weiner <hannes@...xchg.org>