linux-kernel - Re: [PATCH] selftests/ftrace: Use $FUNCTION_FORK to reference kernel fork function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201029153351.m6jvaymzlu34plyk@wittgenstein>
Date:   Thu, 29 Oct 2020 16:33:51 +0100
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] selftests/ftrace: Use $FUNCTION_FORK to reference kernel
 fork function

On Mon, Oct 26, 2020 at 04:20:32PM -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@...dmis.org>
> 
> Commit cad6967ac108 ("fork: introduce kernel_clone()") replaced "_do_fork()"
> with "kernel_clone()". The ftrace selftests reference the fork function in
> several of the tests. The rename will make the tests break, but if those
> names are changed in the tests, they would then break on older kernels. The
> same set of tests should pass older kernels if they have previously passed.
> Obviously, a new test may not work on older kernels if the test was added
> due to a bug or a new feature.
> 
> The setup of ftracetest will now create a $FUNCTION_FORK bash variable
> that will contain "_do_fork" for older kernels and "kernel_clone" for newer
> ones. It figures out the proper name by examining /proc/kallsyms.
> 
> Note, available_filter_functions could also be used, but because some tests
> should be able to pass without function tracing enabled, it could not be
> used.
> 
> Fixes: eea11285dab3 ("tracing: switch to kernel_clone()")
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Thank you!
Acked-by: Christian Brauner <christian.brauner@...ntu.com>