lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <514e13de-b6f6-1df1-ddfe-5a1a2ca8fb87@gmail.com>
Date:   Thu, 29 Oct 2020 23:11:51 +0100
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jonathan Corbet <corbet@....net>, Dan Murphy <dmurphy@...com>,
        Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 33/33] docs: ABI: unify
 /sys/class/leds/<led>/max_brightness documentation

Hi Mauro,

Patch title needs fixing:

s/max_brightness/brightness/

On 10/28/20 3:23 PM, Mauro Carvalho Chehab wrote:
> This ABI is defined twice, one for normal leds and another
> one for multicolor ones.
> 
> Ensure that just one definition is there at ABI.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
>   Documentation/ABI/testing/sysfs-class-led     | 25 ++++++++++++++++---
>   .../ABI/testing/sysfs-class-led-multicolor    | 23 +++++------------
>   2 files changed, 28 insertions(+), 20 deletions(-)
> 
[...]
> +
>   What:		/sys/class/leds/<led>/max_brightness
>   Date:		March 2006
>   KernelVersion:	2.6.17
> diff --git a/Documentation/ABI/testing/sysfs-class-led-multicolor b/Documentation/ABI/testing/sysfs-class-led-multicolor
> index eeeddcbdbbe3..16fc827b10cb 100644
> --- a/Documentation/ABI/testing/sysfs-class-led-multicolor
> +++ b/Documentation/ABI/testing/sysfs-class-led-multicolor
> @@ -1,20 +1,3 @@
> -What:		/sys/class/leds/<led>/brightness
> -Date:		March 2020
> -KernelVersion:	5.9
> -Contact:	Dan Murphy <dmurphy@...com>
> -Description:	read/write
> -		Writing to this file will update all LEDs within the group to a
> -		calculated percentage of what each color LED intensity is set
> -		to. The percentage is calculated for each grouped LED via the
> -		equation below:


-- 
Best regards,
Jacek Anaszewski

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ