linux-kernel - Re: [PATCH 7/7] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 29 Oct 2020 15:11:54 -0700
From:   Prashant Malani <pmalani@...omium.org>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH 7/7] platform/chrome: cros_ec_typec: Register partner
 altmodes

Hi Heikki,

Thank you for reviewing the patch!

On Wed, Oct 28, 2020 at 03:17:32PM +0200, Heikki Krogerus wrote:
> Hi,
> 
> On Wed, Oct 21, 2020 at 01:53:16PM -0700, Prashant Malani wrote:
> > +static void cros_typec_unregister_altmodes(struct cros_typec_data *typec, int port_num)
> > +{
> > +	struct cros_typec_port *port = typec->ports[port_num];
> > +	struct cros_typec_altmode_node *node;
> > +
> > +	while (!list_empty(&port->partner_mode_list)) {
> > +		node = list_first_entry(&port->partner_mode_list, struct cros_typec_altmode_node,
> > +					list);
> 
>         ...
>         struct cros_typec_altmode_node *node, *tmp;
> 
>         list_for_each_entry_safe(node, tmp, &port->partner_mode_list, list) {
> 

Nice; I will make this update in v2. Thanks!

Best regards,

-Prashant