linux-kernel - Re: [PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJht_EOKd_08JnAoUQqn_jrLntew0ymX7Y2bDK-d=EqnyJaWkw@mail.gmail.com>
Date:   Thu, 29 Oct 2020 16:10:53 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Krzysztof Halasa <khc@...waw.pl>
Subject: Re: [PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using
 "goto rx_drop" to drop frames

On Thu, Oct 29, 2020 at 10:00 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> This does change rx_dropped count on errors. Not sure how important
> that is. But perhaps good to call out in the commit explicitly if it's
> intentional.

Yes, this is intentional, because I think we need to count it as a
"drop" whenever we drop an skb. I'll note this explicitly in the
commit message in the next versions of the patch. Thanks!