linux-kernel - Re: [PATCH net-next v3 2/4] net: hdlc_fr: Change the use of "dev" in fr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJht_EPzFiNXjOLgPTrJbMU=e_akB0bEK1zib0SCtVWCvm5sbA@mail.gmail.com>
Date:   Thu, 29 Oct 2020 16:15:29 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Network Development <netdev@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Krzysztof Halasa <khc@...waw.pl>
Subject: Re: [PATCH net-next v3 2/4] net: hdlc_fr: Change the use of "dev" in
 fr_rx to make the code cleaner

On Thu, Oct 29, 2020 at 9:58 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> No need for dev at all then?

Right, there's no need for "dev" at all actually. I kept "dev" just to
keep the code for updating "dev->stats" simpler, because otherwise we
need to write "skb->dev->stats" instead, and there are 3 lines where
we need to write it.