linux-kernel - RE: [PATCH v3] i2c: designware: call i2c_dw_read_clear_intrbits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5DB475451BAA174CB158B5E897FC1525B1294F5F@MBS07.vivotek.tw>
Date:   Wed, 28 Oct 2020 05:24:18 +0000
From:   <Michael.Wu@...ics.com>
To:     <jarkko.nikula@...ux.intel.com>,
        <andriy.shevchenko@...ux.intel.com>,
        <mika.westerberg@...ux.intel.com>, <linux-i2c@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <morgan.chang@...ics.com>
Subject: RE: [PATCH v3] i2c: designware: call
 i2c_dw_read_clear_intrbits_slave() once

Hi,

> On 10/23/20 8:40 AM, Michael Wu wrote:
> > If some bits were cleared by i2c_dw_read_clear_intrbits_slave() in
> > i2c_dw_isr_slave() and not handled immediately, those cleared bits would
> > not be shown again by later i2c_dw_read_clear_intrbits_slave(). They
> > therefore were forgotten to be handled.
> >
> > i2c_dw_read_clear_intrbits_slave() should be called once in an ISR and take
> > its returned state for all later handlings.
> > ---
> >   drivers/i2c/busses/i2c-designware-slave.c | 7 +------
> >   1 file changed, 1 insertion(+), 6 deletions(-)
> >
> Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>

There is another logic issue about the I2C_SLAVE_WRITE_REQUESTED reporting.
May I give patches based on this commit?

Michael Wu